Fix: propagate elements metrics to their shadow nodes #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperzolkiewski
changed the title
jakex7
requested changes
Nov 12, 2025
common/cpp/react/renderer/components/rnsvg/RNSVGComponentDescriptor.h
Outdated
Show resolved
Hide resolved
common/cpp/react/renderer/components/rnsvg/RNSVGComponentDescriptor.h
Outdated
Show resolved
Hide resolved
common/cpp/react/renderer/components/rnsvg/RNSVGLayoutableShadowNode.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Grzywacz <[email protected]>
…iptor.h Co-authored-by: Jakub Grzywacz <[email protected]>
Co-authored-by: Jakub Grzywacz <[email protected]>
…owNode.cpp Co-authored-by: Jakub Grzywacz <[email protected]>
…iptor.h Co-authored-by: Jakub Grzywacz <[email protected]>
jakex7
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2796
Fixes: #2083
Previously, in the new architecture, shadow nodes for elements such as
Circle,Rectand otherSVGcomponents were initialized with zero dimensions.This caused issues with press interactions during move action. Yoga was unable to locate the corresponding shadow node resulting in the press event being canceled.
This PR updates the implementation to propagate each element’s actual native layout metrics to its shadow node.
By ensuring the shadow nodes reflect accurate geometry, Yoga can now correctly resolve touch targets fixing the issue where press actions were being incorrectly canceled.
Test Plan
Compatibility
Checklist
README.md__tests__folder